Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cache in runners #3739

Merged
merged 6 commits into from
Apr 5, 2023
Merged

Use cache in runners #3739

merged 6 commits into from
Apr 5, 2023

Conversation

syrusakbary
Copy link
Member

Runners were missing cache, which caused loading times to be non-ideal when running containers.

This PR fixes it by adding a new function with_compiler to each of the Runners

ptitSeb
ptitSeb approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@ptitSeb ptitSeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@syrusakbary syrusakbary enabled auto-merge April 4, 2023 07:50
@syrusakbary
Copy link
Member Author

The tests that didn't pass are just flaky. Merging manually

@syrusakbary syrusakbary disabled auto-merge April 5, 2023 04:20
@syrusakbary syrusakbary merged commit eb7282a into master Apr 5, 2023
@syrusakbary syrusakbary deleted the runner-cache branch April 5, 2023 04:20
This was referenced Apr 20, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-F-Bryan Michael-F-Bryan Michael-F-Bryan left review comments

@ptitSeb ptitSeb ptitSeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syrusakbary @ptitSeb @Michael-F-Bryan